fix: gate the curate shell test in CI and pre-commit - #35
Merged
Conversation
tests/test_okf_curate.sh shipped in v0.3.1 referenced by neither the workflow nor the pre-commit hook, so the repo's first shell test protected nothing. It covers the post-edit hook -- the component that shipped configured-but-never-firing for two releases. A check that exists but never runs is that same defect wearing different clothes, which is a poor thing to reintroduce in the release that fixed it. Found by the design-doc pass, which grepped both gate files rather than assuming a committed test was a running one. Verified the gate bites: restoring the old hard-coded path filter in okf-curate.sh fails the suite and pre-commit refuses the commit. 01KZ2EWBA88ZH2GBSBPCX8B42H Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKmdobV4dykomYAENb3USC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/test_okf_curate.shshipped in v0.3.1 referenced by neither the CI workflow nor the pre-commit hook. The repo's first shell test protected nothing.What it covers is the point: the post-edit hook — the component that shipped configured but never firing for two releases, which is the headline bug v0.3.0 fixed. A check that exists but never runs is that same defect wearing different clothes, and reintroducing it in the release that fixed it would have been a poor joke.
Two lines, one per gate.
How it was found
The design-doc agent grepped both gate files instead of assuming a committed test was a running one. Confirmed independently — the only match for "curate" in either file was a comment:
Verified the gate actually bites
Same check applied to the graph suite in #8: restore the defect and confirm the gate refuses.
Restored, gate silent, exit 0.
Worth noting the first attempt at this verification was inconclusive and looked like a pass:
pre-commitwas failing earlier on roadmap staleness (I'd just filed the work item) and never reached the test line. Rendering the roadmap first made the real result visible. A guard you "verified" against an already-failing gate is not verified.🤖 Generated with Claude Code
https://claude.ai/code/session_01LKmdobV4dykomYAENb3USC