Add Viewer#sendDeathProtection()

[MrHell228]

SpongeAPI | Sponge

With introduction of DEATH_PROTECTION item component it's now possible to play death protection effect with any ItemStack

[aromaa]

Calling this just sendDeathProtection is going to be very vague. It should at least imply that its just visual effect. Also I think I would rather just call it totemOfUndying because thats very discoverable and understandable. Something like playConsumedTotemOfUndyingEffect, its a bit wordy and lengthy but at least the intent is clear.

[MrHell228]

I believe the fact that it's the method in Viewer interface implies visual-only effect? If not, I can add client-only words to docs, some other methods there has this as well. But I don't really want to blend item name into method name.
Also there will be Keys.DEATH_PROTECTION_EFFECTS from other PR and I don't think you would like it to be called TOTEM_OF_UNDYING_EFFECTS? Maybe rename to playDeathProtectionEffect would be enough

[aromaa]

Effects aren't abstract thing, you want to play a specific one. Abstracting things out works well in the Data API because its a common entrypoint for basically anything. Its much easier to describe the actual effects based on from where they originate. I'm just not buying it that "death protection" is specific enough to distinct itself from any other possible options (Vanilla only has one for now).

[aromaa]

I should also add that the "death protection" term itself is also a very abstract concept. It could mean various things like the player is actively being protected from death, like invincibility, and many games display this by making the player semi transparent or distort the player model in different ways.

[MrHell228]

Yeah, effects aren't abstract thing, I meant that it would be nice to have some consistency between these two things and if you find one, you will likely search for the same name because they originate from the same thing.
I have really no idea if someone is typing player.totem and then autocomplete. If you just find this method on player, I think it's the docs who should say you that in vanilla this is what totem usually does (And even in vanilla with command you can give yourself item that behaves like totem and on death it will pop on the screen as an actual item, not totem)

[MrHell228]

I guess I can agree that it's abstract enough. But playConsumedTotemOfUndyingEffect... eh, too long and inconvenient. But apparently playTotemOfUndyingEffect is shorter than playDeathProtectionEffect. Still don't like item name being involved, but will change to it