Skip to content

add a script that automates the nfo creation process #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TheIceCreamTroll
Copy link
Collaborator

Describe your changes

This adds the script I created to automatically tag new One Pace episodes. It works most of the time, just make sure to always double check the output with the One Pace site

@TheIceCreamTroll TheIceCreamTroll force-pushed the tools branch 2 times, most recently from 76cfafd to 1a0adec Compare June 1, 2024 01:12
@monkTertman
Copy link

Thanks for this work @TheIceCreamTroll.
I was just thinking about writing a similar script and then stumbled upon here.
One quick suggestion I have is showing user the info of each new NFO file being created and user can confirm individually OR all to finally create them.
Also, adding a little bit of test at the start to detect if one pace updated something in their website could prevent junk scrapping.

@SpykerNZ
Copy link
Owner

This is great work. I've been holding off merging it into master as was not sure if belongs there. I would prefer leaving separate on the 'tools' branch, with perhaps a note in the README for those keen to utilize this.

I prefer to keep master with just the setup files to have it less cluttered for users. Open to opinions otherwise :)

@TheIceCreamTroll
Copy link
Collaborator Author

Thanks for the feedback @monkTertman! I'm a fan of your idea to preview new NFO files. I'll probably try and make it open the file in VSCode / the user's default editor so that they can edit the file if needed, as it's more convenient than doing it afterwards.

Unfortunately I don't think we can do any version checking for One Pace's website, since version numbers only really exist in their Discord server.

@SpykerNZ Yeah I also wasn't too sure where to put this. A tools branch certainly works, but it adds extra room for git gore when adding a new episode, as tools has to be kept up to date with main.

Perhaps we could toss it in a tools or devtools folder? It would still be extra clutter, but it would at least be separate from the main tools. We could also add a CONTRIBUTING.md file to properly document the NFO creation process.

@SpykerNZ
Copy link
Owner

@TheIceCreamTroll a tools or devtools folder should be fine too. You are welcome to create a CONTRIBUTING.md document as well.

@HeartPerfusion
Copy link

any tips on getting this to work? I cant seem to make it generate new NFOs for the new episodes

@TheIceCreamTroll
Copy link
Collaborator Author

Running the script should just be python nfo_generator.py. Also make sure you change the paths between lines 13 and 17 to match your system. tmm_folder should be the folder the new video files are located (I need to rename that variable now that tmm isn't used...). library_path should be where you want the renamed video file + nfo file to end up. I have this pointed to my plex library

@HeartPerfusion
Copy link

yeah im using your updated generator.py from January, i totally forgot to change the folder locations is why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants