fix: style ExternalOidc login button on identity-server pages#1325
Open
sinadarbouy wants to merge 1 commit into
Open
Conversation
* Introduced a new button for OIDC authentication in _theme.html. * Added corresponding styles for the OIDC button in _bootstrap.scss. * Defined a new color variable for OIDC in _vars.scss. * Updated icon styles in style.css to include OIDC icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes unstyled external OIDC login buttons on identity-server pages (
/identity-server/account/login/and profile external-login links).When
identity.oidc*is configured, Squidex registers the authentication scheme asExternalOidc. The Razor views derive CSS classes from the scheme name (ExternalOidc→btn-externaloidc,icon-externaloidc), but the theme only defined variants for GitHub, Google, Microsoft, and Twitter.This PR adds the missing button variant, color variable, and icon alias so generic OIDC providers render consistently with other external login buttons.
Before / After
Before
Unstyled plain text — no background color, no icon:


After
Styled button with icon, visually distinct from GitHub/Google/Microsoft:


Root cause
Login.cshtmlandProfile.cshtmluse:The OIDC scheme name is ExternalOidc (Squidex.Web.Constants.ExternalScheme), but
_bootstrap.scsshad nobtn-externaloidcrule and icomoon had no icon-externaloidc.Color choice
Generic OIDC is intentionally not styled as a specific IdP brand (Auth0, Azure AD, Okta, etc.). The slate blue-gray (#526484) reads as neutral enterprise SSO and stays visually distinct from:
How to test
identity.allowPasswordAuth: trueoridentity.allowCustomDomains: trueso the login page is shown instead of auto-redirecting when only one provider is configured./identity-server/account/login/and verify the OIDC button has background color and icon.Checklist