AUTODNS: Enable "get-zones" (ListZones, EnsureZoneExists, GetRegistrarCorrections) #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One wasn't handled, the other one can have the error path dealt with directly in a conditional.
We already advertised providers.CanGetZones, but ZoneLister's ListZones() wasn't implemented yet.
This is trying to lookup a zone (as in DNS), not a domain (as in Registrar).
This allows inspecting on the callsite if zone doesn't exist, or if its another error.
This implements ZoneCreator for AUTODNS, allowing dnscontrol to create zones if they don't already exist. The API insists nameservers and soa to be set, so we use some dummy values, they'll get overwritten later anyways. This makes use of the previous error wrapping commit, to check whether the zone exists currently.
These are sent when an API request triggers a longer-running background task. Log a FUTUREWORK, if it becomes necessary to poll for completion.
This implements registrar support, allowing to update NS records for the apex.
flokli
changed the title
|
cc @arnoschoon |
|
Code looks good to me. @arnoschoon, do you approve? |
tlimoncelli
approved these changes
May 12, 2025
|
Hi @flokli , thanks a bunch for adding this functionality. I'm with @tlimoncelli on this, it looks good to me and more importantly most of the tests still execute correctly so managing records keeps working. Except |
arnoschoon
approved these changes
May 13, 2025
This is the exact failing testcase:
Highly doubt that's due to the changes in this PR. |
Which parts are you confused about? Happy to clarify things. |
Sounds like AUTODNS doesn't support 0-length TXT records. This will fix it: |
|
pushed, thanks! |
tlimoncelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by commit.
ListZones
We already advertised
providers.CanGetZones, butZoneLister'sListZones()wasn't implemented yet. Adding support is very simple, we just need toPOST zone/_searchwithout filters. I made some of the error paths more concise (if err := …; err != nil { … })EnsureZoneExists
This allows to create new zones. We do some error wrapping before to be able to distinguish a zone not existing from other failures, and then create the zone with dummy values, using the
POST /zoneendpoint.Registrar support
Use the
GET domain/{name}endpoint to retrieve nameserver config of a domain, and usePUT domain/{name}to update it. ThenGetRegistrarCorrectionscan simply compare the list of nameservers retrieved ongetDomainwith the desired values, and if different, do a (sparse) request to update these values.I had to juggle some of the provider initialization around, to be able to use the same code for DomainServiceProvider and RegistrarType. We'll end up with two instances, but considering both deal with rate limiting it should be fine, and much more complicated if we'd try to aggregate clients based on the same settings, as rate-limits are per user.