DOCS: Fix incorrect hetzner links #3988
Merged
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Good catch! We renamed some files/directories and missed those links. Thanks for the PR! |
tlimoncelli
changed the title
Collaborator
Author
|
@tlimoncelli the page hasn't updated yet, did I change the wrong/right place? there are others which aren't hetzner which are also broken, should I PR those as well? |
Collaborator
|
@cafferata can you please advise? |
Collaborator
Sure! I see you (@tlimoncelli) reverted theses changes in 7db2055 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to look at the Hetzner V2 documentation and found they were based on an external link which wasn't working. I think this is the fix but I might be wrong.
Also I don't think any of the external links are working on the providers index page https://docs.dnscontrol.org/provider/index
I wonder if these are all dead links which create external links when the site is compiled?