Skip to content

Fix GET detail route when id is array (single vs multi-id) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johanek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix GET detail route when id is array (single vs multi-id) #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3581c62
Fix GET detail route when id is array (single vs multi-id)
johanek Mar 3, 2026
bfb2404
Fix NetBox GET detail route id handling
johanek Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions actions/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,37 @@ def run(self, endpoint_uri, http_verb, get_detail_route_eligible, fail_non_2xx,
StackStorm action entry point.
"""
if http_verb == "get":
if kwargs.get("id", False) and get_detail_route_eligible:
# modify the `endpoint_uri` to use the detail route
endpoint_uri = "{}{}/".format(endpoint_uri, str(kwargs.pop("id")))
self.logger.debug(
"endpoint_uri transformed to {} because id was passed".format(endpoint_uri)
)
id_param = kwargs.get("id")
if get_detail_route_eligible and id_param:
# Scalar or 1-elem list -> detail route; multi-elem list -> list filter
if isinstance(id_param, (list, tuple)):
if len(id_param) == 1:
detail_id = id_param[0]
kwargs.pop("id")
endpoint_uri = "{}{}/".format(endpoint_uri, str(detail_id))
self.logger.debug(
"endpoint_uri transformed to {} (single id from list)".format(
endpoint_uri
)
)
# else: len > 1 -> keep id in kwargs for list filter, no endpoint change
else:
# scalar id -> detail route
detail_id = kwargs.pop("id")
endpoint_uri = "{}{}/".format(endpoint_uri, str(detail_id))
self.logger.debug(
"endpoint_uri transformed to {} because id was passed".format(
endpoint_uri
)
)

if kwargs.get("save_in_key_store") and not kwargs.get("save_in_key_store_key_name"):
return (False, "save_in_key_store_key_name MUST be used with save_in_key_store!")
if kwargs.get("save_in_key_store") and not kwargs.get(
"save_in_key_store_key_name"
):
return (
False,
"save_in_key_store_key_name MUST be used with save_in_key_store!",
)

result = self.make_request(endpoint_uri, http_verb, **kwargs)

Expand All @@ -38,7 +60,9 @@ def run(self, endpoint_uri, http_verb, get_detail_route_eligible, fail_non_2xx,
key_name = kwargs["save_in_key_store_key_name"]
client.keys.update(
KeyValuePair(
name=key_name, value=json.dumps(result), ttl=kwargs["save_in_key_store_ttl"]
name=key_name,
value=json.dumps(result),
ttl=kwargs["save_in_key_store_ttl"],
)
)

Expand Down
Loading