STAC-24297: add worked OpenTelemetry webshop example to the generic s…#6
STAC-24297: add worked OpenTelemetry webshop example to the generic s…#6aacevedoosorio wants to merge 2 commits into
Conversation
| highlight: | ||
| title: "Cart instance" | ||
| # Most fields (Namespace / Instance ID / Version) are inherited from | ||
| # microservice.sty; `fields` is required, so we keep just Labels here. |
There was a problem hiding this comment.
is this an annoyance we should fix?
There was a problem hiding this comment.
I'm not sure of the semantics. How are you supposed to define to have a highlights but only with the inherited fields? Do you need to define a highlight section or not?
There was a problem hiding this comment.
but of course if you want to extend it just with related resources for example you do not want to define fields at all
There was a problem hiding this comment.
Just made the experiment and the highlight fields would compose OK without the fields. I guess I'll make it optional
| ## Development Workflow | ||
|
|
||
| ### 1. Modify Your StackPack | ||
| ```bash |
There was a problem hiding this comment.
A useful command in the dev workflow is the test-deploy sub-command (it's still feature flagged, though).
| tagKey: "cluster-name" | ||
| moreTab: "<< .DisplayName >>" | ||
| topology: | ||
| layer: |
There was a problem hiding this comment.
layer and domain are no longer on the model.
| presentation: | ||
| icon: !icon microservice.svg | ||
| topology: | ||
| layer: |
There was a problem hiding this comment.
layer and domain are no longer on the model.
| projection: | ||
| _type: TagProjection | ||
| provisioning: | ||
| externalComponentSelector: "external.mapping.identifier == 'urn:stackpack:<< .Name >>:otel-component-mapping:database'" |
There was a problem hiding this comment.
Shouldn't the field be topologySourceSelector? https://github.com/StackVista/stackstate-openapi/blob/master/spec_domain/settings.yaml#L1200
| filter: | ||
| _type: "TagFilter" | ||
| tagKey: "service.namespace" | ||
| moreTab: "<< .DisplayName >>" |
There was a problem hiding this comment.
This looks like it should be menuSection: https://github.com/StackVista/stackstate-openapi/blob/master/spec_domain/settings.yaml#L1111
3 participants
…caffold template