Chunk list of flaky items #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stummi
commented
Apr 10, 2025
Comment on lines
+124
to
+131
| occurrences_by_ann_path: Dict[str, List[Occurrence]] = {} | ||
| for o in occurrences: | ||
| occurrences_by_ann_path.setdefault(o.annotation_path, []).append(o) | ||
| items = [i for i in occurrences_by_ann_path.items()] | ||
| items.sort(key=lambda i: len(i[1]), reverse=True) # sort by number of occurrences, highest first | ||
|
|
||
| limit = 12 | ||
| items = items[:limit] |
Contributor
Author
There was a problem hiding this comment.
The diff is a bit weird here. These lines did not change at all. The definition of the json structure and this code block has just been swapped in the code
Stummi
commented
Apr 10, 2025
Comment on lines
+161
to
+162
| data = { | ||
| "channel": state.slack_channel, |
Contributor
Author
There was a problem hiding this comment.
Instead of working with a static string and doing replacements there, we now have a data structure that gets serialized to json later
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
find_flaky_tests.py:147
- [nitpick] The iteration variable 'i' is ambiguous; consider renaming it to 'index' for improved clarity.
content += " ".join([f"<{occr.check_url}|{i+1}> " for i, occr in enumerate(recent_occrs)])
find_flaky_tests.py:182
- [nitpick] Consider renaming the variable 'json' to something more descriptive (e.g., 'json_message') to avoid shadowing the built-in json module.
json = json_lib.dumps(data, indent=4)
flaxel
approved these changes
Apr 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
The list of items to show in the slack message is now split into chunks with 5 items each. This allows us to stay within the documented limit of 3000 characters for individual sections in a box kit slack message
Checklist