Skip to content

Fix poster grabbing & fix tests #18

Merged
StalkR merged 3 commits intoStalkR:masterfrom
ultravioletasdf:master
Jun 2, 2025
Merged

Fix poster grabbing & fix tests #18
StalkR merged 3 commits intoStalkR:masterfrom
ultravioletasdf:master

Conversation

@ultravioletasdf
Copy link
Copy Markdown
Contributor

Added a fallback condition to try get the titles poster by finding the media id and calling NewMedia
Tests had issues where the season count or rating had changed, made changes to get rid of that issue

@StalkR
Copy link
Copy Markdown
Owner

StalkR commented Jun 1, 2025

Thanks for the PR.

The intent is for Title to contain most available information from the title page, without needing a secondary request. Poster was there so I added it, but I consider it secondary. The caller can make a secondary request (with NewMedia) if they wish the poster.

I did notice it broke, but haven't got to look into it yet. If you're able to extract the poster from the title page as before, feel free to send a PR.

I take note of the other changes too (removing struct name + rating).

@ultravioletasdf
Copy link
Copy Markdown
Contributor Author

Yeah, that makes sense.
Turns out the issue with getting with the poster was just finding the media ID, so I replaced titlePoster2RE with a working one and that seemed to fix it, and it doesn't send a secondary request any more.

@StalkR
Copy link
Copy Markdown
Owner

StalkR commented Jun 2, 2025

Looks great, thank you!

I'm curious if we could still have the precompiled regex that doesn't specifically need the current title id, but I'll check that some other time, for now this is just fine.

@StalkR StalkR merged commit 2575fcf into StalkR:master Jun 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants