Skip to content

Conversation

ldr709
Copy link

@ldr709 ldr709 commented Sep 14, 2019

This is not ready for merge. Issues:

Doesn't support __fields or __physical. It would need to know the privileges on the fields during type checking, but that information is now calculated later. Breaking the circular dependency probably wouldn't be too difficult, but it would be annoying to have to go back and fix up the type checked AST after finding the privileges. One failing test case is run_pass/call_terra_region.rg.

Index launch checking is less complete. I didn't get around to implementing the check to see if two regions are always distinct for all pairs of iterations. This would just need some metadata to tell if a parent region was declared outside the loop. A failing test case is run_pass/optimize_index_launch_num.rg.

flow_from_ast.t still tries to use the old constraint data, even though it isn't there anymore. It hasn't been converted to using the new interface for getting constraint information. This makes run_pass/parallelize_tasks_hint_color_space.rg fail, among others.

@magnatelee magnatelee self-requested a review December 6, 2019 00:22
@magnatelee magnatelee added this to the 19.12 milestone Dec 6, 2019
@magnatelee magnatelee added enhancement planned Feature/fix to be actively worked on - needs release target Regent Issues pertaining to Regent labels Dec 6, 2019
@magnatelee magnatelee modified the milestones: 19.12, 20.03 Dec 31, 2019
@elliottslaughter elliottslaughter modified the milestones: 20.03, 20.06 Apr 1, 2020
@elliottslaughter elliottslaughter modified the milestones: 20.06, 20.12 Sep 22, 2020
@streichler
Copy link
Contributor

@elliottslaughter @magnatelee what's the plan for this?

@elliottslaughter
Copy link
Contributor

I think @magnatelee looked at this and I believe our concern was about compile times. I think it's still very desirable feature but just haven't had time to look in detail at what the impact on compile times is and whether it can be mitigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement planned Feature/fix to be actively worked on - needs release target Regent Issues pertaining to Regent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants