Allow assignment operations on regions in Regent #583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready for merge. Issues:
Doesn't support
__fields
or__physical
. It would need to know the privileges on the fields during type checking, but that information is now calculated later. Breaking the circular dependency probably wouldn't be too difficult, but it would be annoying to have to go back and fix up the type checked AST after finding the privileges. One failing test case isrun_pass/call_terra_region.rg
.Index launch checking is less complete. I didn't get around to implementing the check to see if two regions are always distinct for all pairs of iterations. This would just need some metadata to tell if a parent region was declared outside the loop. A failing test case is
run_pass/optimize_index_launch_num.rg
.flow_from_ast.t
still tries to use the old constraint data, even though it isn't there anymore. It hasn't been converted to using the new interface for getting constraint information. This makesrun_pass/parallelize_tasks_hint_color_space.rg
fail, among others.