Properly support decoding profiles with/without Result#102
Merged
elliottslaughter merged 1 commit intomasterfrom May 22, 2025
Merged
Properly support decoding profiles with/without Result#102elliottslaughter merged 1 commit intomasterfrom
elliottslaughter merged 1 commit intomasterfrom
Conversation
elliottslaughter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to correctly parse new and old profiles, we have to first attempt to decode the result as
data::Result<T>, and then a second time as plainT.Previously we were missing the first, and newer profiles did not decode at all. I missed the error before because the
Resulttype generated by the nice error message was fully pluggable with the rest of the system. The new code is much more explicit about what type we're decoding.