C API for instance layout v1 #276
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable cuhook build by default, add option See merge request StanfordLegion/legion!1810
Realm: disable barrier broadcast See merge request StanfordLegion/legion!1809
disable cuhook build by default, add option See merge request StanfordLegion/legion!1810 (cherry picked from commit eb1ec26) f6d559c disable cuhook build by default, add option 08572ac Merge branch 'master' into sm/fix_cuhook_make Co-authored-by: Seema Mirchandaney <[email protected]>
Realm: disable barrier broadcast See merge request StanfordLegion/legion!1809 (cherry picked from commit 3eba361) 8bb9bfb realm: add broadcast kill-switch dd232c7 realm: add broadcast kill-switch 548e198 realm: remove assert 3609e63 realm: fix clang-format c33960f realm: undo cmake changes aa277d0 realm: remove empty line 487652d realm: disable fragmentation 3478e0e realm: disable broadcast_previous 539601f realm: disable tests 925078f realm: completely disable broadcast paths fe8daf5 realm: undo test changes bae24d7 realm: undo changes to runtime_impl.h ea18bec realm: fix radix 6542a35 realm: fix clang-format 166f0c2 realm: fix typo dace381 realm: undo lines 359e7c9 realm: undo namespace changes Co-authored-by: apryakhin <[email protected]>
[P0] build: Turn RDTSC off by default until we can put the PPC check back See merge request StanfordLegion/legion!1816
[P0] build: Turn RDTSC off by default until we can put the PPC check back See merge request StanfordLegion/legion!1816 (cherry picked from commit 9a4604e) 83ea9d6 build: Turn RDTSC off by default until we can put the PPC check back. Co-authored-by: Elliott Slaughter <[email protected]>
realm: fix and add capi tests See merge request StanfordLegion/legion!1812
[P0] test: Match the allocation function used in test See merge request StanfordLegion/legion!1817
[P0] test: Match the allocation function used in test See merge request StanfordLegion/legion!1817 (cherry picked from commit a101776) f753d5d test: Match the allocation function used in test. Co-authored-by: Elliott Slaughter <[email protected]>
update realm release notes for 25.06 See merge request StanfordLegion/legion!1818
Change the behavior to check the target was defined and the feature was enabled before setting it to be used/built. This is useful when the project is built as part of other projects that may have found a package but do not necessarily want that feature to be built by this project.
* Add sanitizer tests for ASAN, TSAN, and UBSAN * Unfortunately we have a leak in the python module, so disable that. * Fix a couple of found leaks * Add ucx and gasnet builds to the ci
* Fix up cuda compile args to compile SASS for everything up to the last architecture, adding ptx for the latest (fixing an issue with r580 when both sass and ptx is available for a removed architecture) * Add a REALM_DEFAULT_ARGS environment and put the default test arguments here, prepended to what is set in the test environment at runtime. This allows us to set the default, but allow the test environment to override it. * This allows us to, by default, enable GPU tests with one gpu, but override it in the test environment for more than one GPU
This changes request_cancellation to return a bool stating success/fail and also refactors the flow to make it readable.
fixup! Add the ASSERT_REALM macro to machine_config_test to make it more readable (#259)
This eliminates the need for timed_wait as a separate function. Then update the tests to the new API definition
As discussed in slack, the `CompiledProgram` is only used when MultiAffine accessor is created, so to avoid the exhaustion of replicated heap, we can lazily create the `CompiledProgram` only when `get_lookup_program` is called.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 26.23% 26.70% +0.46%
==========================================
Files 185 186 +1
Lines 38783 39049 +266
Branches 14187 14197 +10
==========================================
+ Hits 10175 10428 +253
+ Misses 27412 27406 -6
- Partials 1196 1215 +19 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this first version, we implemented an instance layout structure only for dense affine layout. In this version, the C struct
realm_instance_layout_tis NOT the same as C++'s InstanceLayout class. Instead, it only contains necessary parameters used for creating a dense affine layout, and internally we use the helper functionchoose_instance_layoutto convert the c structure into the C++ object. In the next version, we will update therealm_instance_layout_tto be a real affine layout.