-
Notifications
You must be signed in to change notification settings - Fork 10
Address list refactoring #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: apriakhin <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage ? 27.22%
=======================================
Files ? 189
Lines ? 39321
Branches ? 14364
=======================================
Hits ? 10707
Misses ? 28240
Partials ? 374 ☔ View full report in Codecov by Sentry. |
*/ | ||
template <int N, typename T> | ||
inline int | ||
compact_affine_dims(const AffineLayoutPiece<N, T> *affine, const Rect<N, T> &subrect, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2dm Why do we ned compact_affine_dims here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had the same comment on the other PR before the split. You are correct that it's not used here, but it produces the inputs for append_entry, so I think it's more clear to see where it comes from.
We can go either way with this if you changed your mind.
namespace Realm { | ||
|
||
template <typename FieldID> | ||
struct FieldBlockBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@2dm I think this concept probably need to be re-worked. That should probably be on me to do that. FieldBlock somehow doesn't fit naturally into the address lis and I am thinking that we should re-design this data structure.
No description provided.