Skip to content

Conversation

2dm
Copy link
Collaborator

@2dm 2dm commented Sep 21, 2025

No description provided.

@2dm 2dm self-assigned this Sep 21, 2025
Copy link

codecov bot commented Sep 21, 2025

Codecov Report

❌ Patch coverage is 93.95973% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@9181321). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/realm/transfer/address_list.cc 89.47% 10 Missing and 2 partials ⚠️
src/realm/inst_layout.inl 0.00% 3 Missing ⚠️
src/realm/transfer/transfer.cc 40.00% 3 Missing ⚠️
src/realm/transfer/transfer_utils.inl 89.65% 3 Missing ⚠️
src/realm/inst_impl.cc 0.00% 2 Missing ⚠️
src/realm/transfer/lowlevel_dma.cc 0.00% 2 Missing ⚠️
src/realm/idx_impl.cc 0.00% 1 Missing ⚠️
tests/unit_tests/address_list_test.cc 99.58% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage        ?   27.22%           
=======================================
  Files           ?      189           
  Lines           ?    39321           
  Branches        ?    14364           
=======================================
  Hits            ?    10707           
  Misses          ?    28240           
  Partials        ?      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apryakhin apryakhin self-requested a review September 23, 2025 18:31
*/
template <int N, typename T>
inline int
compact_affine_dims(const AffineLayoutPiece<N, T> *affine, const Rect<N, T> &subrect,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2dm Why do we ned compact_affine_dims here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had the same comment on the other PR before the split. You are correct that it's not used here, but it produces the inputs for append_entry, so I think it's more clear to see where it comes from.
We can go either way with this if you changed your mind.

namespace Realm {

template <typename FieldID>
struct FieldBlockBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@2dm I think this concept probably need to be re-worked. That should probably be on me to do that. FieldBlock somehow doesn't fit naturally into the address lis and I am thinking that we should re-design this data structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants