add unit benchmark for remote channel #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 26.62% 27.23% +0.61%
==========================================
Files 188 190 +2
Lines 39015 39530 +515
Branches 14155 14428 +273
==========================================
+ Hits 10388 10767 +379
- Misses 27222 27882 +660
+ Partials 1405 881 -524 ☔ View full report in Codecov by Sentry. |
apryakhin
reviewed
Oct 1, 2025
| int num_channels{100}; | ||
| }; | ||
|
|
||
| BENCHMARK_F(RemoteChannelFixture, BenchSupportsChannel)(benchmark::State& state) { |
There was a problem hiding this comment.
Are we planning to run this as a part of Q/A test suite?
apryakhin
reviewed
Oct 1, 2025
| uint64_t best_time = 0; | ||
| Realm::XferDesKind best_kind = Realm::XferDesKind::XFER_NONE; | ||
| for (int i = 0; i < num_channels; i++) { | ||
| best_time = channels[i]->supports_path(channel_copy_infos[i], 0, 0, 0, 10000, nullptr, nullptr, &best_kind, nullptr, nullptr); |
There was a problem hiding this comment.
nit: please document all hard-coded values that you are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit benchmark using google benchmark for the
supports_pathof the remote channel. We can kind of use it to reproduce the realm regression we had before. Here is some performance data on my workstation with release build:Without the fix:
With the fix: