Add dynamic loading of ucx and ucc #323
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 27.15% 27.38% +0.23%
==========================================
Files 190 190
Lines 39174 39188 +14
Branches 14166 14412 +246
==========================================
+ Hits 10638 10732 +94
- Misses 27240 28061 +821
+ Partials 1296 395 -901 ☔ View full report in Codecov by Sentry. |
muraj
force-pushed
the
cperry/ucx-dyn
branch
from
44e7b68 to
3e3f01e
Compare
eddy16112
approved these changes
Oct 7, 2025
|
|
||
| status = ucc_collective_finalize(req); | ||
| ucc_check(status); | ||
| status = wait(context, [&req]() { return req->status; }); |
There was a problem hiding this comment.
NIT: it is better to use ucc_collective_test even though it is the same as req->status, we do not need to know the implementation of a request.
| { | ||
| assert(initialized_boot); | ||
|
|
||
| ucc_comm->UCC_Finalize(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.