Consolidate loader logic to cross platform class #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 27.15% 27.28% +0.12%
==========================================
Files 190 193 +3
Lines 39174 39232 +58
Branches 14166 14288 +122
==========================================
+ Hits 10638 10703 +65
- Misses 27240 27820 +580
+ Partials 1296 709 -587 ☔ View full report in Codecov by Sentry. |
muraj
force-pushed
the
cperry/loader
branch
4 times, most recently
from
1ea99d0 to
beeb413
Compare
apryakhin
reviewed
Oct 2, 2025
|
|
||
| #include "realm/gasnetex/gasnetex_internal.h" | ||
|
|
||
| #include "realm/runtime_impl.h" |
There was a problem hiding this comment.
don't we have a loader for UCX as well? I think the bootstrap loader?
|
I am ready to approve. Overall that's looking good. I will do a few more passes though. |
muraj
force-pushed
the
cperry/loader
branch
4 times, most recently
from
ee08f7b to
25b2842
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a Loader class that can be used to easily create a dynamic loader for a library and works across platforms.