Skip to content

Add rsrv logger for machine topology #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elliottslaughter wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rsrv logger for machine topology #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/realm/runtime_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ namespace Realm {

Logger log_runtime("realm");
Logger log_collective("collective");
Logger log_rsrv("rsrv");
extern Logger log_task; // defined in proc_impl.cc
extern Logger log_taskreg; // defined in proc_impl.cc
extern Logger log_machine; // defined in machine_impl.cc
Expand Down Expand Up @@ -2241,9 +2242,20 @@ namespace Realm {
// threads that have already been requested
bool ok = core_reservations->satisfy_reservations(config->dummy_reservation_ok);
if(ok) {
// The topology/reservation dump can go to stdout (-ll:show_rsrv) and/or to
// the "rsrv" logger (-level rsrv=2); both are independent. Funnel each
// active sink through the same ostream-based formatting so it isn't
// duplicated - operator<<(HardwareTopology) and report_reservations()
// already take a generic std::ostream&.
auto report_topology = [&](std::ostream &os) {
os << host_topology << std::endl;
core_reservations->report_reservations(os);
};
if(config->show_reservations) {
std::cout << host_topology << std::endl;
core_reservations->report_reservations(std::cout);
report_topology(std::cout);
}
if(LoggerMessage msg = log_rsrv.info(); msg.is_active()) {
report_topology(msg.get_stream());
}
} else {
printf("HELP! Could not satisfy all core reservations!\n");
Expand Down
Loading