Correctly pass scale to pybullet API#235
Open
fjulian wants to merge 1 commit intoStanfordVL:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, setting a scale different from 1 for YCB objects has no effect. This is because the scale is passed as scalar to the pybullet API (
createCollisionShapeandcreateVisualShape), instead of as a vector of length 3 (as mentioned in the pybullet documentation). Unfortunately, pybullet seems to ignore the scale parameter silently if it is given in the wrong format.This PR fixes the issue by passing the scale as an iterable of length 3. I updated this in the code for all of the above mentioned pybullet API calls that pass a scale.