Skip to content

Commit

Permalink
perf(dropdown): ⚡️ use content-visibility for icons and dropdown menus
Browse files Browse the repository at this point in the history
This will reduce the initial render cost of the menus, and also prevent premature download
for the icons.
  • Loading branch information
alistair3149 committed Nov 6, 2024
1 parent e1b89d5 commit 70193eb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 5 additions & 1 deletion resources/skins.citizen.styles/components/Dropdown.less
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
.citizen-dropdown {
.citizen-menu__card {
z-index: @z-index-dropdown;
content-visibility: hidden;
max-width: 80vw;
transition-timing-function: var( --transition-timing-function-ease-in );
transition-duration: var( --transition-duration-base );
transition-property: transform;
transition-property: transform, content-visibility;
transition-behavior: allow-discrete;

> * {
opacity: 0;
transition-timing-function: var( --transition-timing-function-ease-in );
transition-duration: var( --transition-duration-base );
transition-property: opacity;
Expand Down Expand Up @@ -58,6 +61,7 @@
&-details {
&[ open ] {
+ .citizen-menu__card {
content-visibility: visible;
transition-timing-function: var( --transition-timing-function-ease-out );
transition-duration: var( --transition-duration-medium );
transform: none;
Expand Down
5 changes: 1 addition & 4 deletions resources/skins.citizen.styles/components/Menu.less
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
box-shadow: var( --box-shadow-drop-xx-large );
transform: scale( 0 );
contain: content;

> * {
opacity: 0;
}
}

&__heading {
Expand Down Expand Up @@ -80,6 +76,7 @@
height: var( --size-icon );
min-height: var( --size-icon );
contain: strict;
content-visibility: auto;

&::before {
display: block;
Expand Down

0 comments on commit 70193eb

Please sign in to comment.