Skip to content

Conversation

yandongxiao
Copy link
Collaborator

Description

From StarRocks 3.4.1, the shared-data mode cluster supports disaster recovery. The Operator can configure the disaster
recovery for the shared-data mode cluster to ensure the data security and high availability.

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

@yandongxiao yandongxiao marked this pull request as ready for review February 18, 2025 07:55
Copy link
Collaborator

@kevincai kevincai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me, check if we can move the disaster recovery setting and status to crd level instead of each subcontroller.

type: string
type: object
type: array
disasterRecovery:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a cluster-wise property, no need to break down to sub controllers?

@yandongxiao yandongxiao requested a review from kevincai February 19, 2025 07:50
@yandongxiao yandongxiao merged commit b22497d into StarRocks:main Feb 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants