feat(helm): expose waitForFullRollout in kube-starrocks chart#771
Merged
Conversation
waitForFullRollout was added to the CRD/types/controllers in StarRocks#739 but the chart never rendered spec.waitForFullRollout and had no values knob, so Helm users could not enable it. Add the values key to both the starrocks subchart and the parent chart, and render it onto the StarRocksCluster spec.
yandongxiao
changed the title
yandongxiao
changed the title
kevincai
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
waitForFullRolloutwas added to the CRD, Go types, and FE/BE/CN controllers in #739, and theoperator honors it — but the Helm chart never exposed it: the
starrockscluster.yamltemplate didnot render
spec.waitForFullRolloutand there was novalues.yamlknob. Helm users thereforecould not enable the feature without manually patching the CR.
What this changes
spec.waitForFullRolloutonto theStarRocksCluster(guarded, same style asdisasterRecovery).waitForFullRollout: falseunderstarrocksClusterin both thestarrockssubchart valuesand the parent
kube-starrocksvalues, with a doc comment.The chart's bundled CRD already includes the field, so no CRD change is needed.
Verification
helm template … --set starrocks.starrocksCluster.waitForFullRollout=truerendersspec.waitForFullRollout: true; default render omits it.StarRocksClusterCR (CRD accepts the field).helm lint+helm templatepass.