[BugFix] Allow non-reserved keywords FLOOR/CEIL as column names (backport #75241) (backport #75292) (#75295)

Signed-off-by: wyb <wybb86@gmail.com>
Co-authored-by: wyb <wybb86@gmail.com>

Author: mergify[bot]

fe/fe-core/src/main/java/com/starrocks/sql/ast/UnitBoundary.java

@@ -466,7 +466,6 @@
 import com.starrocks.sql.ast.TruncateTableStmt;
 import com.starrocks.sql.ast.UninstallPluginStmt;
 import com.starrocks.sql.ast.UnionRelation;
-import com.starrocks.sql.ast.UnitBoundary;
 import com.starrocks.sql.ast.UnitIdentifier;
 import com.starrocks.sql.ast.UnsupportedStmt;
 import com.starrocks.sql.ast.UpdateFailPointStatusStatement;
@@ -589,6 +588,13 @@ public class AstBuilder extends StarRocksBaseVisitor<ParseNode> {
             Lists.newArrayList(FunctionSet.SUBSTR, FunctionSet.SUBSTRING,
                     FunctionSet.FROM_UNIXTIME, FunctionSet.FROM_UNIXTIME_MS,
                     FunctionSet.STR2DATE);
+
+    // Boundary keywords accepted as the third argument of time_slice / date_slice
+    // (e.g. time_slice(dt, interval 5 minute, FLOOR)); the lower-case form is what the
+    // function implementation expects.
+    private static final String TIME_SLICE_BOUNDARY_FLOOR = "floor";
+    private static final String TIME_SLICE_BOUNDARY_CEIL = "ceil";
+
     // rewriter
     private static final CompoundPredicateExprRewriter COMPOUND_PREDICATE_EXPR_REWRITER = new CompoundPredicateExprRewriter();
 
@@ -7311,6 +7317,23 @@ private static void addArgumentUseTypeInt(Expr value, List<Expr> exprs) {
         }
     }
 
+    // time_slice / date_slice accept FLOOR or CEIL (case-insensitive) as their boundary argument,
+    // e.g. time_slice(dt, interval 5 minute, FLOOR). FLOOR and CEIL are non-reserved keywords, so the
+    // parser builds a column reference (SlotRef) for the bare keyword; recognize it here and normalize
+    // to the lower-case string the function implementation expects.
+    private static String getTimeSliceBoundary(ParseNode boundaryArg, String functionName) {
+        if (boundaryArg instanceof SlotRef) {
+            SlotRef slotRef = (SlotRef) boundaryArg;
+            if (slotRef.getTblNameWithoutAnalyzed() == null && slotRef.getColumnName() != null) {
+                String boundary = slotRef.getColumnName().toLowerCase();
+                if (boundary.equals(TIME_SLICE_BOUNDARY_FLOOR) || boundary.equals(TIME_SLICE_BOUNDARY_CEIL)) {
+                    return boundary;
+                }
+            }
+        }
+        throw new ParsingException(PARSER_ERROR_MSG.wrongTypeOfArgs(functionName), boundaryArg.getPos());
+    }
+
     @Override
     public ParseNode visitSimpleFunctionCall(StarRocksParser.SimpleFunctionCallContext context) {
         String fullFunctionName = getQualifiedName(context.qualifiedName()).toString();
@@ -7328,7 +7351,7 @@ public ParseNode visitSimpleFunctionCall(StarRocksParser.SimpleFunctionCallConte
                 IntervalLiteral intervalLiteral = (IntervalLiteral) e2;
                 FunctionCallExpr functionCallExpr = new FunctionCallExpr(fnName, getArgumentsForTimeSlice(e1,
                         intervalLiteral.getValue(), intervalLiteral.getUnitIdentifier().getDescription().toLowerCase(),
-                        "floor"), pos);
+                        TIME_SLICE_BOUNDARY_FLOOR), pos);
 
                 return functionCallExpr;
             } else if (context.expression().size() == 3) {
@@ -7340,13 +7363,10 @@ public ParseNode visitSimpleFunctionCall(StarRocksParser.SimpleFunctionCallConte
                 IntervalLiteral intervalLiteral = (IntervalLiteral) e2;
 
                 ParseNode e3 = visit(context.expression(2));
-                if (!(e3 instanceof UnitBoundary)) {
-                    throw new ParsingException(PARSER_ERROR_MSG.wrongTypeOfArgs(functionName), e3.getPos());
-                }
-                UnitBoundary unitBoundary = (UnitBoundary) e3;
+                String boundary = getTimeSliceBoundary(e3, functionName);
                 FunctionCallExpr functionCallExpr = new FunctionCallExpr(fnName, getArgumentsForTimeSlice(e1,
                         intervalLiteral.getValue(), intervalLiteral.getUnitIdentifier().getDescription().toLowerCase(),
-                        unitBoundary.getDescription().toLowerCase()), pos);
+                        boundary), pos);
 
                 return functionCallExpr;
             } else if (context.expression().size() == 4) {
@@ -8042,11 +8062,6 @@ public ParseNode visitUnitIdentifier(StarRocksParser.UnitIdentifierContext conte
         return new UnitIdentifier(context.getText(), createPos(context));
     }
 
-    @Override
-    public ParseNode visitUnitBoundary(StarRocksParser.UnitBoundaryContext context) {
-        return new UnitBoundary(context.getText(), createPos(context));
-    }
-
     @Override
     public ParseNode visitDereference(StarRocksParser.DereferenceContext ctx) {
         Expr base = (Expr) visit(ctx.base);

fe/fe-core/src/main/java/com/starrocks/sql/parser/AstBuilder.java

@@ -2576,7 +2576,6 @@ literalExpression
     | (DATE | DATETIME) string                                                            #dateLiteral
     | string                                                                              #stringLiteral
     | interval                                                                            #intervalLiteral
-    | unitBoundary                                                                        #unitBoundaryLiteral
     | binary                                                                              #binaryLiteral
     | PARAMETER                                                                           #Parameter
     ;
@@ -2940,10 +2939,6 @@ unitIdentifier
     : YEAR | MONTH | WEEK | DAY | HOUR | MINUTE | SECOND | QUARTER | MILLISECOND | MICROSECOND
     ;
 
-unitBoundary
-    : FLOOR | CEIL
-    ;
-
 type
     : baseType
     | decimalType

fe/fe-core/src/main/java/com/starrocks/sql/parser/StarRocks.g4

@@ -189,6 +189,38 @@ void testNonReservedWords_2() {
         }
     }
 
+    @Test
+    void testFloorCeilAsIdentifier() {
+        // FLOOR and CEIL are non-reserved keywords (the time_slice/date_slice boundary argument).
+        // They must remain usable as ordinary identifiers (column / table names) and must not be
+        // parsed as a UnitBoundary literal in expression position. Regression for:
+        // "class com.starrocks.sql.ast.UnitBoundary cannot be cast to ...ast.expression.Expr".
+        SessionVariable sessionVariable = new SessionVariable();
+        List<String> sqls = Lists.newArrayList(
+                // bare keyword as a column reference (the originally reported failure)
+                "select floor from t",
+                "select ceil from t",
+                "select floor, ceil from t",
+                "select floor + 1 as c from t",
+                "select * from t where floor > 1 and ceil < 2",
+                "select floor as f from t group by floor order by floor",
+                // back-quoted / qualified / as a table name
+                "select `floor` from t",
+                "select t.floor from t",
+                "select * from floor",
+                // the time_slice/date_slice boundary keyword must still parse
+                "select time_slice(th, interval 1 year, floor) from t",
+                "select time_slice(th, interval 1 year, CEIL) from t",
+                "select date_slice(th, interval 1 year, ceil) from t");
+        for (String sql : sqls) {
+            try {
+                SqlParser.parse(sql, sessionVariable).get(0);
+            } catch (Exception e) {
+                fail("sql should succeed: " + sql + " errMsg: " + e.getMessage());
+            }
+        }
+    }
+
     @Test
     void testParseLargeDecimal() {
         String sql = "select cast(1 as decimal(65,0))";

fe/fe-core/src/test/java/com/starrocks/sql/parser/ParserTest.java

@@ -0,0 +1,36 @@
+-- name: test_keyword_column_name
+-- FLOOR and CEIL are non-reserved keywords (the time_slice/date_slice boundary argument).
+-- Regression: they must be usable as ordinary column names in queries, and must not be parsed
+-- as a UnitBoundary literal (which previously raised
+-- "class com.starrocks.sql.ast.UnitBoundary cannot be cast to ...ast.expression.Expr").
+create database db_${uuid0};
+-- result:
+-- !result
+use db_${uuid0};
+-- result:
+-- !result
+create table t (floor int, ceil int) distributed by hash(floor);
+-- result:
+-- !result
+insert into t values(1, 2);
+-- result:
+-- !result
+select floor from t;
+-- result:
+1
+-- !result
+select ceil from t;
+-- result:
+2
+-- !result
+select floor, ceil from t;
+-- result:
+1	2
+-- !result
+select floor + ceil as s from t;
+-- result:
+3
+-- !result
+drop database db_${uuid0};
+-- result:
+-- !result

test/sql/test_create_table/R/test_keyword_column_name

@@ -0,0 +1,14 @@
+-- name: test_keyword_column_name
+-- FLOOR and CEIL are non-reserved keywords (the time_slice/date_slice boundary argument).
+-- Regression: they must be usable as ordinary column names in queries, and must not be parsed
+-- as a UnitBoundary literal (which previously raised
+-- "class com.starrocks.sql.ast.UnitBoundary cannot be cast to ...ast.expression.Expr").
+create database db_${uuid0};
+use db_${uuid0};
+create table t (floor int, ceil int) distributed by hash(floor);
+insert into t values(1, 2);
+select floor from t;
+select ceil from t;
+select floor, ceil from t;
+select floor + ceil as s from t;
+drop database db_${uuid0};