[BugFix] Fix query profile API to return a unified JSON format #67077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaohehuhu <[email protected]>
Contributor
Author
|
@kevincai plz help review |
kevincai
reviewed
Dec 22, 2025
fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the query profile API was returning a double-wrapped JSON response when fetching profiles from other frontend nodes. The fix ensures a unified JSON format is returned regardless of whether the profile is found locally or on a remote frontend.
Key Changes:
- Deserialize JSON responses from other frontends to extract the profile string from the
RestBaseResultV2wrapper before re-wrapping it for the final response - Add necessary imports (
TypeTokenandGsonUtils) to support JSON deserialization
fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java
Show resolved
Hide resolved
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java
Show resolved
Hide resolved
Signed-off-by: zhaohehuhu <[email protected]>
Contributor
|
@cursor review |
kevincai
previously approved these changes
Dec 24, 2025
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
Contributor
|
@cursor review |
fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/http/rest/v2/ProfileActionV2.java
Show resolved
Hide resolved
Signed-off-by: zhaohehuhu <[email protected]>
Contributor
|
@cursor review |
Signed-off-by: zhaohehuhu <[email protected]>
Signed-off-by: zhaohehuhu <[email protected]>
|
Contributor
|
@cursor review |
Contributor
Author
|
@kevincai look like the CI was broken. Could you plz help rerun CI pipeline ? |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 7 / 8 (87.50%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
approved these changes
Dec 27, 2025
Contributor
|
@cursor review |
alvin-celerdata
approved these changes
Dec 27, 2025
|
@Mergifyio backport branch-4.0 |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 27, 2025
Signed-off-by: zhaohehuhu <[email protected]> (cherry picked from commit 52b3a8a)
23 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 27, 2025
…ort #67077) (#67280) Signed-off-by: zhaohehuhu <[email protected]> Co-authored-by: He Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
as title
What I'm doing:
as title
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Aligns cross-FE profile fetching to return the plain-text profile inside the standard JSON envelope.
ProfileActionV2, when querying other FEs, parse their JSON (RestBaseResultV2<String>) and return only theresult(plain text); skip null resultsGsonUtils/TypeTokenusage to deserialize remote responsesProfileActionV2Testto assert JSON envelope (status=OK) and that the embedded profile is plain text (not JSON)Written by Cursor Bugbot for commit a58535a. This will update automatically on new commits. Configure here.