-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[BugFix] Fix NPE in Iceberg metadata table query due to missing Configuration propagation #67151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[BugFix] Fix NPE in Iceberg metadata table query due to missing Configuration propagation #67151
Conversation
|
@cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
|
Could you please review this PR when you have a chance? All CI checks have passed with 100% coverage on the changed lines. Thanks! |
|
@mergify rebase |
Signed-off-by: jiwon <[email protected]>
…guration propagation Signed-off-by: jiwon <[email protected]>
Signed-off-by: jiwon <[email protected]>
✅ Branch has been successfully rebased |
464e980 to
423804d
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 2 / 2 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |



Why I'm doing:
When querying Iceberg metadata tables (history, snapshots, refs, etc.),
NPE occurs with message: "Cannot invoke Configuration.size() because conf is null".
This happens because:
IcebergCachingFileIO.getWrappedIO()returnsResolvingFileIOwithout Configuration setSerializableTableserializes the FileIO, it callsserializeConfWith()SerializableConfSupplierconstructor callsconf.size()on null ConfigurationWhat I'm doing:
Fix
getWrappedIO()to propagate Configuration to wrappedIO before returning.confis set viasetConf(), use itconfis null (e.g., REST catalog), use defaultnew Configuration()What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Bugfix: propagate Hadoop
Configurationto wrappedFileIOIcebergCachingFileIO.getWrappedIO()to setwrappedIO's conf using existingconfor a defaultnew Configuration()to avoid NPE duringserializeConfWithsetConf()inIcebergCachingFileIOTestWritten by Cursor Bugbot for commit 423804d. This will update automatically on new commits. Configure here.