[Enhancement] statistics sql skip backlist check #67174
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seaven <[email protected]>
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (context.isStatisticsConnection() || context.isStatisticsJob()) { | ||
| // For statistics connection or job, we trust it and skip sql blacklist check | ||
| LOG.debug("skip sql blacklist check for statistics connection or job. stmt: {}", | ||
| origStmt.originStmt); |
There was a problem hiding this comment.
NullPointerException when accessing origStmt for statistics logging
The code accesses origStmt.originStmt for debug logging when context.isStatisticsConnection() or context.isStatisticsJob() is true, but origStmt can be null since parsedStmt.getOrigStmt() may return null. The original code had the null check as the first condition, but the new statistics check happens before verifying origStmt != null, causing a potential NullPointerException.
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 2 / 3 (66.67%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kangkaisen
approved these changes
Dec 26, 2025
stephen-shelby
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Behavioral tweak in
StmtExecutorQueryStatement/InsertStmt/CreateTableAsSelectStmt, whenConfig.enable_sql_blacklistis on, skip verifying against the SQL blacklist if the context is a statistics connection or job; otherwise proceed as before.Scope: FE query execution path around blacklist validation. Risk: Low; limited to statistics contexts.
Written by Cursor Bugbot for commit 646ecda. This will update automatically on new commits. Configure here.