Skip to content

Conversation

@eshishki
Copy link
Contributor

@eshishki eshishki commented Dec 26, 2025

Why I'm doing:

enable_min_max_optimization lacked min max meta scan for iceberg partition columns

What I'm doing:

Teach HdfsScannerContext::create_min_max_value_column to do TYPE_DATETIME

For timestamp_tz we do adjust on FE side, since it is FE who reads meta bounds and BE can't access them. Can redo in favor of addind is_adjusted_to_utc to TExprMinMaxValue in thrift. But wanted to keep it simpler.

Fixes #67158

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • [] Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.0
    • 3.5
    • 3.4
    • 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Queries over Iceberg don't use Iceberg metadata

1 participant