[BugFix] Fix multi result sinks error for single-tablet queries in shared-data mode #67240
+66
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Why I'm doing:
PR #66517 introduced single-tablet result sink optimization in shared-data mode, but it causes
ERROR 1064 (HY000): This sql plan has multi result sinksfor queries like UNION with user variables.The issue is that only the top fragment was marked with
isSingleTabletGatherOutputFragment, while intermediate fragments (e.g., AGGREGATE) were still assigned to all compute nodes by theisPreferComputeNodestrategy, creating multiple result sink instances.What I'm doing:
isSingleTabletGatherOutputFragmentflag when single-tablet optimization is triggeredisPreferComputeNodestrategy for fragments marked withisSingleTabletGatherOutputFragmentFixes #issue
https://github.com/StarRocks/StarRocksTest/issues/10756
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Fixes single-tablet planning in shared-data mode by correctly marking gather fragments and adds regression tests.
PlanFragmentBuilder, when single-tablet optimization/short-circuit applies, setisSingleTabletGatherOutputFragmenton all non-ScanNodefragments instead of only the input fragmentJoinTestto validateRESULT SINK/AGGREGATE (merge finalize)withUNIONtest_union_all_with_limitSQL tests with a duplicate-key table and aUNIONover a session variable to cover result planningWritten by Cursor Bugbot for commit 7ffab44. This will update automatically on new commits. Configure here.