[Feature] Implement Regexp_Position in C++ mode #67252
Open
+555
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chewbum
changed the title
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
|
@mergify rebase |
Contributor
✅ Branch has been successfully rebased |
alvin-celerdata
force-pushed
the
regexp_position
branch
from
b8d7f28 to
75eb4c1
Compare
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
| context->set_function_state(scope, state); | ||
|
|
||
| // check if pattern is constant | ||
| if (context->is_constant_column(1)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (context->is_constant_column(1)) { | |
| if (!context->is_constant_column(1)) { | |
| return Status::OK(); | |
| } |
|
|
||
| -- name: test_regexp_position | ||
|
|
||
| SELECT regexp_position('a.b:c;d', '[.]'); |
Contributor
There was a problem hiding this comment.
All the cases are testing the optimized logic. Please add some cases to test the general path.
And please add some cases to test invalid inputs, like null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
REGEXP_Position is supported by Trino but not supported by StarRocks
When this function call is passed to StarRocks in my company's scenario, this will result in error
What I'm doing:
Returns the position of the specified occurrence of the regular expression pattern in the string subject
Fixes #67246
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Introduces
regexp_positionto return the 1-based position of the Nth regex match in a string, with UTF-8 correctness and error handling.StringFunctions::regexp_positionwith prepare/close, constant-pattern optimization, UTF-8 code-point indexing, support forstart_posandoccurrence, returns-1when not found, and surfaces invalid regex errors.REGEXP_POSITIONtoFunctionSet; analyzer fills default args (start_pos=1, occurrence=1) and resolves builtin viagetRegexpPositionFunction.gensrc/script/functions.pywith INT return and prepare/close hooks.Written by Cursor Bugbot for commit 75eb4c1. This will update automatically on new commits. Configure here.