You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support the array join syntax of Clickhouse， eg: select id, c1 from t1 array join array_col as c1
What I'm doing:
Convert ARRAY JOIN to UNNSET + LATERAL JOIN
eg: ARRAY JOIN array_col To JOIN LATERAL UNNEST(array_col) LEFT ARRAY JOIN array_col To LEFT JOIN LATERAL UNNEST(array_col)
Fixes #issue
What type of PR is this:
BugFix
Feature
Enhancement
Refactor
UT
Doc
Tool
Does this PR entail a change in behavior?
Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.
If yes, please specify the type of change:
Interface/UI changes: syntax, type conversion, expression evaluation, display information
Parameter changes: default values, similar parameters but with different default values
Policy changes: use new policy to replace old one, functionality automatically enabled
Feature removed
Miscellaneous: upgrade & downgrade compatibility, etc.
Checklist:
I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
I have added documentation for my new feature or new function
This pr needs auto generate documentation
This is a backport pr
Bugfix cherry-pick branch check:
I have checked the version labels which the pr will be auto-backported to the target branch
4.0
3.5
3.4
3.3
Note
Introduces ClickHouse-style ARRAY JOIN syntax by rewriting it to LATERAL UNNEST, with left join support and correctness checks.
Parser/AST: Extend grammar with arrayJoinClause; in AstBuilder, transform ARRAY JOIN ... (and LEFT ARRAY JOIN ...) into JOIN LATERAL UNNEST(...), set aliases, output column names, and join type
Analyzer: In QueryAnalyzer, propagate isLeftJoin and new isArrayJoin to TableFunction; keep lateral join constraints for unnest
FE/BE plumbing: Add is_array_join to TTableFunction (Thrift) and FE TableFunction; add _is_array_join_mode to BE TableFunctionState with getters/setters
Execution: In MultiUnnest, validate all arrays have equal length when in array-join mode, error if mismatched; preserve left-join null filling
Tests: Add SQL tests for ARRAY JOIN and LEFT ARRAY JOIN on arrays
Written by Cursor Bugbot for commit 966a927. This will update automatically on new commits. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
Copy constructor omits isArrayJoin flag
The TableFunction copy constructor does not copy the new isArrayJoin field (nor the pre-existing isLeftJoin field). When copy() is called on a TableFunction that has isArrayJoin set to true, the copied function will have isArrayJoin as false (the default value), losing the flag. While the current ARRAY JOIN implementation doesn't call copy() on the function after setting this flag, future code modifications could trigger this bug, causing the array size validation in the backend to be silently skipped.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zhaorui9303
force-pushed
the
fix_array_join
branch
from
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Why I'm doing:
Support the array join syntax of Clickhouse， eg:
select id, c1 from t1 array join array_col as c1What I'm doing:
Convert ARRAY JOIN to UNNSET + LATERAL JOIN
eg:
ARRAY JOIN array_col To JOIN LATERAL UNNEST(array_col)LEFT ARRAY JOIN array_col To LEFT JOIN LATERAL UNNEST(array_col)Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
Note
Introduces ClickHouse-style
ARRAY JOINsyntax by rewriting it toLATERAL UNNEST, with left join support and correctness checks.arrayJoinClause; inAstBuilder, transformARRAY JOIN ...(andLEFT ARRAY JOIN ...) intoJOIN LATERAL UNNEST(...), set aliases, output column names, and join typeQueryAnalyzer, propagateisLeftJoinand newisArrayJointoTableFunction; keep lateral join constraints forunnestis_array_jointoTTableFunction(Thrift) and FETableFunction; add_is_array_join_modeto BETableFunctionStatewith getters/settersMultiUnnest, validate all arrays have equal length when in array-join mode, error if mismatched; preserve left-join null fillingARRAY JOINandLEFT ARRAY JOINon arraysWritten by Cursor Bugbot for commit 966a927. This will update automatically on new commits. Configure here.