-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[Feature] Sparse Delta Column Group (SDCG) for lake PK column-mode partial update (experimental, default-off) #74373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meegoo
wants to merge
1
commit into
StarRocks:main
Choose a base branch
from
meegoo:sdcg-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+9,765
−108
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change adds several mutable BE configuration knobs (for example
enable_sparse_dcgand thesdcg_*thresholds), but I could not find matching entries underdocs/en/ordocs/zh/(rg enable_sparse_dcg docsreturns no hits). The repo AGENTS.md requires user-facing config changes to update the matching docs, and without that operators cannot discover the defaults or the effect of enabling this new write path.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation is intentionally deferred here. This PR is an explicit PoC, and every new config knob (
enable_sparse_dcgand thesdcg_*thresholds) is gated behindenable_sparse_dcg, which defaults to false — with the flag off, behavior is byte-identical to the current code path, so none of these knobs are user-facing yet.The repo rule requires docs for user-facing config changes "when applicable"; for an unreleased, off-by-default experimental feature it is not yet applicable. The PR checklist reflects this deliberately: "This pr needs user documentation" is left unchecked. User-facing docs under
docs/en/anddocs/zh/will be added when the feature graduates from PoC and the flag is enabled by default.Generated by Claude Code