[Refactor] Split schema scanners into layered modules#76241
[Refactor] Split schema scanners into layered modules#76241alvin-phoenix-ai wants to merge 2 commits into
Conversation
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
|
@codex review |
Module-risk briefing for Codex reviewThis is review focus, not a finding list. Validate against the diff. High-confidence risks
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf6d451801
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #include "column/column_helper.h" | ||
| #include "common/runtime_profile.h" | ||
| #include "exec/exec_env.h" |
There was a problem hiding this comment.
Remove the new ExecEnv include from exec scan code
be/src/exec/AGENTS.md:9 explicitly says not to add new production includes of exec/exec_env.h under be/src/exec; this new include (and the matching one added in pipeline/scan/schema_chunk_source.cpp) reintroduces ExecEnv coupling into schema scan execution just to fetch the factory, undercutting the layering this refactor is trying to enforce. Please route the factory through a lower-level scan context/interface instead of adding new ExecEnv dependencies here.
Useful? React with 👍 / 👎.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: