Skip to content

[Refactor] Split schema scanners into layered modules#76241

Closed
alvin-phoenix-ai wants to merge 2 commits into
StarRocks:mainfrom
alvin-phoenix-ai:opt-ss-01
Closed

[Refactor] Split schema scanners into layered modules#76241
alvin-phoenix-ai wants to merge 2 commits into
StarRocks:mainfrom
alvin-phoenix-ai:opt-ss-01

Conversation

@alvin-phoenix-ai

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@github-actions

Copy link
Copy Markdown
Contributor

Module-risk briefing for Codex review

This is review focus, not a finding list. Validate against the diff.

High-confidence risks

@github-actions github-actions Bot requested review from stdpain and wyb July 13, 2026 00:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf6d451801

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


#include "column/column_helper.h"
#include "common/runtime_profile.h"
#include "exec/exec_env.h"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the new ExecEnv include from exec scan code

be/src/exec/AGENTS.md:9 explicitly says not to add new production includes of exec/exec_env.h under be/src/exec; this new include (and the matching one added in pipeline/scan/schema_chunk_source.cpp) reintroduces ExecEnv coupling into schema scan execution just to fetch the factory, undercutting the layering this refactor is trying to enforce. Please route the factory through a lower-level scan context/interface instead of adding new ExecEnv dependencies here.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants