feat(embed): add tqdm progress bar to chunk stage, clean up embed logging#108
Open
yichuan-w wants to merge 1 commit into
Open
feat(embed): add tqdm progress bar to chunk stage, clean up embed logging#108yichuan-w wants to merge 1 commit into
yichuan-w wants to merge 1 commit into
Conversation
…ging - chunk.py: add tqdm progress bar for article-level chunking so users see real-time progress during Stage 2 (e.g. "Chunking: 50%|█████ | 4/8") - embed_cpu.py: remove redundant "Embedded X/Y" logger.info every 10 items — tqdm already shows this and the log lines break the progress bar display Tested with 8 Wikipedia pages (64 chunks produced).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Maybe embedd is bottleneck needing to add progress bar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger.info("Embedded %d/%d")every 10 items — tqdm already shows this info and the log lines break the progress bar display.Closes #99.
Test plan