fix(cli): accept auto/mps devices in index build, with CI-safe test#109
Open
aafaq-rashid-comprinno wants to merge 1 commit into
Open
Conversation
|
@aafaq-rashid-comprinno is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
Adds 'auto' and 'mps' to --device choices for pixelrag index build. The test gracefully skips in CI where the index stage (pyyaml) isn't installed, preventing the ModuleNotFoundError that broke PR StarTrail-org#73. Supersedes StarTrail-org#73 (same fix + CI-compatible test).
158f472 to
6de9510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pixelrag index build --device autofails because argparse only allowscpuandcuda. PR #73 fixed the choices but its test fails in CI becausepixelrag index build --helpimportsconfig.py→yamlwhich isn't installed in core-only CI.Fix
auto,mpsto--devicechoicesSupersedes #73 (same feature fix + working CI).