Added model sizes#168
Closed
sherucon wants to merge 5 commits into
Closed
Conversation
Show model sizes (in MB) right next to model names wherever there is a menu to choose/download a model: - Onboarding screen (OnboardingUnifiedModelItemView) - Model selection screen in settings (ModelDownloadItemView) The implementation follows existing code patterns: - Model size is stored as Integer (MB) in OnboardingUnifiedModel structure - ByteCountFormatter is used to format sizes for display (same as SettingsDownloadableModel) - Parakeet models have size 0 placeholder for future implementation - UI displays sizes in caption2 font below model description
- Remove redundant size field from OnboardingModelType.whisper enum - Keep single size field in OnboardingUnifiedModel (consistent with SettingsDownloadableModel) - Add accurate Parakeet model sizes: v3 (483 MB), v2 (464 MB) - Update sizeString to use model.size instead of extracting from enum - Cleaner, more maintainable architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model Size Display Enhancement
Overview
This PR implements a new feature to display model file sizes right next to model names throughout the OpenSuperWhisper UI, providing users with clear information about the storage requirements of each model they can download.
Closes #143.
Key Features
✅ Onboarding Screen
Model sizes are now displayed in the onboarding view (OpenSuperWhisper/Onboarding/OnboardingView.swift), showing accurate file sizes below each model description.
✅ Settings Model Selection
Model sizes are displayed in the model selection screen within settings (OpenSuperWhisper/Settings.swift), providing storage information for downloadable Whisper and Parakeet models.
Model Sizes Displayed
Technical Improvements
1. Unified Model Size Storage
sizefield fromOnboardingModelTypeenumOnboardingUnifiedModelstructSettingsDownloadableModelfor consistency2. Accurate Parakeet Model Sizes
parakeet_download_analysis.md)3. Fixed Compiler Issues
OnboardingView.swift.whisper(let url, _)to.whisper(let url)to match the updated enum definitionImplementation Details
Files Modified:
OpenSuperWhisper/Onboarding/OnboardingView.swiftOnboardingUnifiedModelItemViewOpenSuperWhisper/Settings.swiftOnboardingModelTypeenumOnboardingUnifiedModelscollectionModelDownloadItemViewto display sizesPattern Used:
Intrepresenting MBByteCountFormatterfor display (same as existing codebase)sizeStringformats for user displayAnalysis Documentation
For detailed information about Parakeet model download sizes, see
parakeet_download_analysis.md:Benefits
User Experience:
Code Quality:
SettingsDownloadableModelpatternTesting
Manual verification completed:
Future Considerations