fix(collector): Fix duplicated/missing temperature datapoints from ata_sct_temperature_history #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes two modification to smart temperature logging: - Even if ata_sct_temperature_history is present, log current time. - Forcefully align each ata_sct_temperature_history data point according to logging interval reported in SMART. This prevents duplicated datapoints. Fixes 824
Owner
Author
Merged to Fork (2025-11-30)Cherry-picked into Starosdev/scrutiny. Changes Made
Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicated or missing recent temperature datapoints caused by ata_sct_temperature_history.
Origin
Cherry-picked from upstream PR: AnalogJ#825
Original author: @CircuitCoder
Changes
Closes #3