chore(annotation): do not clobber existing annotations#26
Merged
Jose-Matsuda merged 3 commits intomasterfrom Mar 10, 2025
Merged
chore(annotation): do not clobber existing annotations#26Jose-Matsuda merged 3 commits intomasterfrom
Jose-Matsuda merged 3 commits intomasterfrom
Conversation
Collaborator
Author
|
Using the above tag i was able to observe the success; Where the STS has the annotation on it; will verify that it works for multiple shares Added an extra share and it is still working as expected, there are no duplicate annotations or anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For BTIS-874
related to StatCan/kubeflow#246
Previously the annotation was not being propagated, this screenshot is from the kerberos sidecar injector but it uses the same logic so we will need to port it there as well.
Also removed an extraneous variable / annotation and combined it.
Using:
61e89f5b03d393bcca846ed71dbfcb72a82d172e