Skip to content

chore(env var): add BUCKET_HOST#28

Merged
Jose-Matsuda merged 1 commit intomasterfrom
bucket-host-env
Apr 4, 2025
Merged

chore(env var): add BUCKET_HOST#28
Jose-Matsuda merged 1 commit intomasterfrom
bucket-host-env

Conversation

@Jose-Matsuda
Copy link
Copy Markdown
Collaborator

for https://jirab.statcan.ca/browse/BTIS-910
Ensure the filer-sidecar-injector-json configmap is updated

@Jose-Matsuda
Copy link
Copy Markdown
Collaborator Author

On dev verified this on a new notebook
image
Used the image tag of c7008d9c87e7afaab1f389eb34ba25fe76ea5c48 as well as updated the filer-sidecar-injector-json configmap (manually first) here to add

{
                    "name": "BUCKET_HOST",
                    "value": "INSERT-BUCKET-HOST"
                }

Copy link
Copy Markdown

@mathis-marcotte mathis-marcotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing screenshot provided looks good

@Jose-Matsuda Jose-Matsuda merged commit 3a835b3 into master Apr 4, 2025
1 check passed
@Jose-Matsuda Jose-Matsuda deleted the bucket-host-env branch April 4, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants