Kf1.9 common lib components update #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing build will be fixed with this pr #339 Failing tests will be fixed with ticket https://jirab.statcan.ca/browse/BTIS-673 |
wg102
requested changes
Feb 25, 2025
...end/common/kubeflow-common-lib/projects/kubeflow/src/lib/form/section/section.component.scss
Show resolved
Hide resolved
...n/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/table/table.component.spec.ts
Show resolved
Hide resolved
...n/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/table/table.component.spec.ts
Show resolved
Hide resolved
frontend/common/kubeflow-common-lib/projects/kubeflow/src/lib/resource-table/table/utils.ts
Show resolved
Hide resolved
.../common/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.scss
Show resolved
Hide resolved
...mmon/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.spec.ts
Show resolved
Hide resolved
...nd/common/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.ts
Show resolved
Hide resolved
.../common/kubeflow-common-lib/projects/kubeflow/src/lib/status-icon/status-icon.component.scss
Show resolved
Hide resolved
wg102
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for https://jirab.statcan.ca/browse/BTIS-661
Just for what is found under
/kubeflow-common-lib/projects/kubeflow/src/lib