Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a second Message Detail serializer, MessageHighlightsSerializer, which takes the same fields as the regular one but instead of subject and body, returns highlighted_subject and highlighted_body.
Does so by getting query param "highlights" provided by front end. If highlights are present, the view will use the MessageHighlightsSerializer. The param is a comma separated list of values to be highlighted. The serializer uses an internal _highlight method to do the highlighting.
The highlighter uses some regex to capture a case-insensitive equivalent of the highlight provided, wrap it with "" tags and then stick it back in where it was before. I'm not sure how well regex will capture special characters, å ø π, so on. I don't know if that's a concern. I suspect people won't be searching much on those characters.