change healthcheck from github.com to raw.githubusercontent.com#22
Open
michelonfelipe wants to merge 1 commit into
Open
change healthcheck from github.com to raw.githubusercontent.com#22michelonfelipe wants to merge 1 commit into
github.com to raw.githubusercontent.com#22michelonfelipe wants to merge 1 commit into
Conversation
since assets are downloaded from raw.githubusercontent.com, this should be the ideal url for a healthcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Recently, when installing decky,
plugin_loader-${BRANCH}.servicehad the content of 429 response from github, instead of the expected contentThis happened because the healthcheck from the beginning of the file only checks for github.com access (which is not actually used), and do not checks for
raw.githubusercontent.comThere was actually a wide problem on south america accessing
raw.githubusercontent.com. More info in an community discussionWhat
Change healthcheck from
github.comtoraw.githubusercontent.comThe default status code is 301, because the homepage redirects to
github.com