Skip to content

Comments

Fix settings import under windows#858

Merged
PartyWumpus merged 4 commits intoSteamDeckHomebrew:mainfrom
suchmememanyskill:main
Dec 20, 2025
Merged

Fix settings import under windows#858
PartyWumpus merged 4 commits intoSteamDeckHomebrew:mainfrom
suchmememanyskill:main

Conversation

@suchmememanyskill
Copy link
Contributor

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: The settings import for some reason does not get picked up by pyinstaller running under windows, but does when running under linux. This PR adds an explicit import for the settings module to resolve this issue.

Effectively, plugins like tabmaster and steamgriddb (that use the settings api) will now work again under windows.

@BassemMohsen
Copy link

Tested on Windows 25 H2, With Steam 1763795278
It works great !

This looks good to me, and hopefully maintainer approves soon.

@BassemMohsen
Copy link

Why is not this merged yet? it passed all checks and no conflicts ?
Do you have to assign reviewers, maybe? who's the maintainer of the repo?

@PartyWumpus PartyWumpus merged commit 7898515 into SteamDeckHomebrew:main Dec 20, 2025
4 checks passed
chenx-dust pushed a commit to chenx-dust/decky-loader that referenced this pull request Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants