Skip to content

Update decky-multi-user to v1.1.0#1057

Open
nikitaclicks wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
nikitaclicks:main
Open

Update decky-multi-user to v1.1.0#1057
nikitaclicks wants to merge 2 commits into
SteamDeckHomebrew:mainfrom
nikitaclicks:main

Conversation

@nikitaclicks

@nikitaclicks nikitaclicks commented May 31, 2026

Copy link
Copy Markdown
Contributor

Update decky-multi-user to v1.1.0

Fixes game page flickering by caching wrapped React type via WeakMap.

Root cause: wrapReactType created a new shallow copy of the ForwardRef/Memo type object on every render (__DECKY_WRAPPED flag set on the copy, not the original). React saw a different .type reference and unmounted/remounted the entire game page subtree, causing cascading OwnerLabel re-fetches.

Fix: cache the wrapped type in a WeakMap so all renders share the same reference. Use a shared renderAppId variable in route-patch scope (not a per-render closure) so the inner afterPatch handler reads the current appId dynamically.

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.
  • Generative AI was NOT used to write a majority of the code I am submitting.
    -- AI (Claude/opencode) was used to help implement the WeakMap cache fix and extract the injectOwnerLabel helper, but all changes were reviewed and tested on-device.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

Testing

  • Tested by a third party on SteamOS Stable or Beta update channel.

@nikitaclicks nikitaclicks requested a review from a team as a code owner May 31, 2026 10:11
@github-actions github-actions Bot added the not-plugin Not related to plugins themselves label May 31, 2026
@github-actions

Copy link
Copy Markdown

Issues Found

  • Neither testing box is present in your description. Please include one of them per the Markdown comment above the testing section.

Next Steps

  1. If we found any issues above, please edit your pull request description to resolve them and leave a comment saying you've done so.
  2. For the quickest review, please see the Community section of the pull request template for how you can help other developers.
  3. Once your description is correct, a maintainer will review your pull request as soon as possible.

Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️

@AAGaming00

Copy link
Copy Markdown
Member

messed up the pr again award

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy.

@github-actions github-actions Bot added the stale label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-plugin Not related to plugins themselves plugin-update Updating a plugin on the Plugin Store stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants