Skip to content

Update SDH-Notebook to 0.1.5 #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

wynn1212
Copy link
Contributor

Notebook

Update SDH-Notebook to v0.1.5

  • Update all dependencies
  • Fix Cannot read property on latest stable release of SteamOS by using Global DFL

This fork has been approved by the original author, @popsUlfr, to submit this pull request in order to address popsUlfr/SDH-Notebook#3 issue.
Since @popsUlfr is currently out of the loop regarding decky and the plugins and does not foresee investing effort into this project in the near future, @popsUlfr has approved me to submit this update, addressing the issue at hand.
However, should @popsUlfr wish to re-engage with this effort, they are always welcome to reclaim ownership of the project.

Source for approval:

Once again, a big thanks to the original author, @popsUlfr, for approving me to submit this updated plugin.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@suchmememanyskill suchmememanyskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing: Seems to work as intended

Steam deck oled
Steamos preview (steam 1719967667)
Decky pre-release v3.0.0-pre2

@twcb
Copy link

twcb commented Jul 26, 2024

what's pending to have this closed?

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's pending to have this closed?

Apologies, much in the way that popsUlfr has been out of the loop for a while now I've been busy with life stuff and have only found time to dedicate myself to plugin reviews and so on again recently.

Testers ascent, update goes to production

@TrainDoctor TrainDoctor merged commit 5b3aaaf into SteamDeckHomebrew:main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants