Usb request enhancements #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Append OUT data only if it has been ACKed. OUT transfers (BULK OUT or CONTROL transfer DATA stage) are typically NACKed to create backpressure. Always keep IN and OUT transfers separate. On the physical layer, the endpoint number only uses 4 bits, and IN and OUT use separate tokens. In case the transfer is an IN transfer, set the high bit as used in the endpoint descriptors (i.e. 0x81 is IN enpoint 1, 0x01 is OUT endpoint 1).
E.g. CONTROL and BULK IN transfers may overlap each other, and as a result only one of the two can be seen in pulseview. Partly solves bug #1046. In case a device has multiple IN/OUT endpoints, transfers would still overlap, but many simple devices have just one each.
From a protocol level, a BULK IN transfer starts when the host starts polling the respective endpoint. For analysis, it is sometimes useful to show when the devices starts to answer the requests. As both are useful for different use cases (the old, default one emphasizes the host behavior, the new one shows the endpoint/device behavior), make the display configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several enhancements to the usb_request decoder