Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to support node-gyp #443

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Update Dockerfile to support node-gyp #443

merged 1 commit into from
Jun 26, 2020

Conversation

amirhalatzi
Copy link
Contributor

After some trial and error, I've added these missing configurations to install node-gyp based packages. See issue #440

After some trial and error, I've added these missing configurations to install `node-gyp` based packages. See issue #440
Copy link
Owner

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@StefanScherer StefanScherer merged commit 4599d9a into StefanScherer:main Jun 26, 2020
@amirhalatzi amirhalatzi deleted the patch-1 branch June 28, 2020 07:39
@amirhalatzi
Copy link
Contributor Author

Thank you for maintaining this repo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants