Skip to content

Windows 7 script improvements #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StefanScherer merged 3 commits into from
Oct 16, 2020
Merged

Windows 7 script improvements #272

StefanScherer merged 3 commits into from
Oct 16, 2020

Conversation

@qmfrederik
Copy link

@qmfrederik qmfrederik commented Jul 2, 2020

  • Show a status message every few minutes when SP1 and the convenience rollup are being installed. On Travis, builds will time out if no log output is written every 5 minutes, and this helps prevent that.
  • There have been improvements in how Ansible, Packer and WinRM interact with each other. Long story short, things have been simplified. Update the Ansible integration to match the recommended method described in the Packer documentation.
  • Update the wording in the update script

These changes have been verified using the CI scripts in #270

qmfrederik added 3 commits July 2, 2020 10:21
@qmfrederik
Keep showing output when Windows 7 SP1 and convenience rollup are ins…
a5a7c3d 
…talling

fixup
@qmfrederik
WinRM improvements
b87f3d7 
- Use the built-in Packer/Ansible/WinRM integration
- Use WinRM over HTTP, because Windows 7 does not support TLSv1.2 out of the box, while Ubuntu Bionic requires TLSv1.2
@qmfrederik
Simplify update script
c3df3cc
@qmfrederik qmfrederik mentioned this pull request Jul 2, 2020
Merged
@qmfrederik
Copy link
Author

qmfrederik commented Oct 16, 2020

@StefanScherer Is this something you'd be interested in merging?

StefanScherer
StefanScherer approved these changes Oct 16, 2020
View reviewed changes
Copy link
Owner

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @qmfrederik for the heads-up! Somehow I missed the notification.
Yes, looks good as it only updates the windows 7 configuration.

@StefanScherer StefanScherer merged commit 45cf498 into StefanScherer:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanScherer StefanScherer StefanScherer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@qmfrederik @StefanScherer