feat: enforce HMAC request signing on admin endpoints - #815
Merged
thlpkee20-wq merged 7 commits intoAug 31, 2026
Conversation
|
@Duyicoda Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an HMAC request-signing middleware for
/api/adminmutating endpoints. It protects/api/admin/purge,/api/admin/reconcile, and the planned outbox requeue route from replay and tampering attacks by requiring an AWS SigV4-style canonical-request signature computed over method, path, query, selected headers, and body — in addition to the existing bearer auth andX-Admin-Tokenchecks. A freshX-Stellabill-Dateheader is required with a 60-second skew tolerance, and replayed signatures are rejected via the sharedwebhook_event_cache.Related Issue
Closes #
Changes
🔐 Admin Request-Signing Middleware
[ADD]
internal/middleware/request_signing.gowebhook_verification.go.X-Stellabill-Datewithin a 60-second skew window; rejects missing or stale dates.webhook_event_cacheand rejecting duplicates.401/403responses for malformed, tampered, expired, or replayed requests.[MODIFY]
internal/middleware/webhook_verification.go[MODIFY]
internal/routes/routes.goadminroute group only, preserving the existing bearer-auth andX-Admin-Tokenauthorization chain.[MODIFY]
internal/handlers/admin.go/api/admin/purgeand/api/admin/reconcile, keeping existing authorization and validation checks intact.[ADD]
docs/admin-signing.md[ADD]
internal/middleware/request_signing_test.go[MODIFY]
internal/handlers/admin_test.goVerification Results
request_signing_test.goandadmin_test.goCloses #786