test(agent): add test coverage for completeShutdown - #914
Open
Fathia-tech14 wants to merge 1 commit into
Open
Conversation
- Export completeShutdown from agent/agent.js - Add agent/completeShutdown.test.js with 20 unit tests covering exit code mapping, shutdown timer cancellation, structured event logging, resource disposal, and boundary conditions - Resolves Stellar-Ecosystem#827
|
@Fathia-tech14 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
@Stellar-Ecosystem Hi! This PR is open and ready for review — happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #827
Summary of Changes
completeShutdownfromagent/agent.js.agent/completeShutdown.test.js(20 tests) covering:0onsuccess = true(and truthy boundaries1,"true") and exit code1onsuccess = false(and falsy boundaries0,null,undefined,"",NaN).shutdown_completepayload contains accuratesuccess,unresolvedPayments, andfinalScorefields.shutdownTimer(initiated viainitiateShutdown) is cleared withclearTimeout.dispose()is called prior to process termination.Verification
Ran
npx vitest runinagent/: