fix(contract,backend): store AgentIds as Vec<BytesN<32>> and chunk into 500-item pages (#247) - #917
Open
Bojest001 wants to merge 1 commit into
Open
Conversation
|
@Bojest001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247
Changes
Contract Storage Optimization ():
DataKey::AgentIdsto storeVec<BytesN<32>>instead of heavyVec<Address>objects, saving ~40% storage overhead by keeping only the raw 32-byte Ed25519 public key.address_to_bytes32andbytes32_to_addressBase32 + CRC16 conversion helpers to convert seamlessly betweenAddressandBytesN<32>.DataKey::AgentIdsBytesPage(u32)pages of 500BytesN<32>entries each (~16KB per page), preventing storage limit bottlenecks.list_agentsandlist_agents_pageto reconstructAddressfrom raw 32-byte keys forDataKey::Agentlookups.get_agent_idsandget_agent_ids_pagecontract entry points.Registry Contract Confirmation ():
DataKey::ServiceIdsusesVec<u64>compact integer ScVal representation (8 bytes per entry, ~8,000 services before 64KB limit).Backend ():
addressToBytes32andbytes32ToAddresshelper functions usingStrKey.mapAgentandmapPolicyto automatically handle Buffer / Uint8Array raw 32-byte representations as well as Address objects and string addresses.getAgentIdsandgetAgentIdsPageclient methods to reconstruct addresses from raw byte entries.Testing & Documentation:
addressToBytes32,bytes32ToAddress,mapAgentwith Buffer addresses,getAgentIds, andgetAgentIdsPageinbackend/src/lib/contract.test.js.README.mddocumentation.